* Added unit test for Array.prototype mangling - first passing version
* Enhanced unit test for prototype stressing to catch more illegal for-in loops
* Fixed all for-in linting violations
* Corrects usage of @static jsdoc annotation
* Correct unresolvable types
* Correct types in jsdoc and remove extraneous @class & @constructor jsdoc
* Remove incorrect @static jsdoc
* Adds missing jsdoc for param copyFromGlobals
* correct jsdoc in util
* Corrects casing on jsdocs
* Swaps @inheritDoc to @ignore for constructors where constructor args are documented in the class
* Instantiates Errors with `new`
* Addresses improperly defined @callback tags.
* Split callbacks out to separate jsdoc
* Moves constructor jsdocs back to constructor and drop @ignore.
* Enables require MethodDefinition for require-jsdoc lint rule and corrects 66% of missing Method Definitions
* Adds jsdoc for all remaining methods and corrects @class/@constructor documentation
* Define values more accurately
* Correct bugs that prevent jsdoc generation
* Proof of concept with copied options + handling from network
* Added unit test for Graph3d, for checking default syntax; completed def's of all options, autoByDefault not handled yet.
* Fixes for options in playground example
* Added onclick options to graph3d documentation
* Fixes in graph3d examples
* Final fixes for option definitions in Graph3d
* Fixed handling of 'undefined' in options, enhanced graph3d unit test
* Disabled console output in graph3d unit test
* Upgrade webpack module
* Graph3D: move Filter into DataGroup
The `Filter` instance within `Graph3d` is intimately connected to the graph data,
contained in a `DataGroup` instance. As such, it needs to be placed within `DataGroup`.
A consequence of this is that, in the final case of multiple graphs, each graph can be
animation separately. I regard this as an advantage, even though it will means more
initialization for the graphs (you have to initialize each separately for an animation.
An effort has been made to decouple `Graph3d` and `Filter` as much as possible. There
are still some relationships present, but it's more bother than it's worth to dissolve these.
In addition to moving the `Filter` instance, the following has been done:
- Added variable `style` to `DataGroup`
- Moved certain data-specific methods from `Graph3d` to `DataGroup`
- cleaned up some code and commenting
These changes have been tested with the following examples:
- `graph3d/10_styling`
- `graph3d/03_filter_data`
- `graph3d/04_animation`
* Add changes to filter
**Note:** This is a small fix and should be easy to review.
Second fix for #3251.
In method `DataGroup.initializeData()`, if the passed `rawData` is bad for some reason,
it was possible to lose the subscriptions due to early return from the method.
This fix changes the order in the method so that the guard clauses execute *before* the
subscription is changed.
* First working version of eslint enabled with gulp
* Tryout of eslint with graph3d files
* Cleanup of gulp and eslint files.
* Completed test by linting graph3d
* Disable travis linting for now
* Remove global cmd param from .travis.yml
* Fix missing reference to Graph3D instance in DataGroup
Fix for #3251
A reference was missed in DataGroup.reload() during refactoring.
Rather than fix this method, it has been removed and the logic moved to `Graph3d`.
This makes for somewhat cleaner code.
* Fixes due to review
* First working version of new class DataGroup.
* Adjustments for review - done all points except last
* DRY distinct values, clean up sort code
* Added missing @param's to comments in DataGroup
Sorry for the delay on this... It took me a while to confirm this PR again. I don;t know why I didn't merge it at the time I reviewed it. Looks great to me!
* styling support for graph3d tooltips
* styling support for graph3d tooltips
* graph3d styling example, deleted new example and altered the original
* graph3d tooltip styling, documentation
* graph3d tooltip styling, use the util module's method for merging objects
* Added showX(YZ)Axis to Graph3d
* Added show_Axis options to docs and playground example
* Resolved merge conflict
* Added show_Axis options to docs and playground example
* Allow pass the color of points in 'dot-color' mode of Graph3D explicitly - clear the source code and finalize
* Add an onclick callback in Graph3D, to enable click and display customer user-defined information for single data point
* Extra data type validation for string conversion functions in Setings
* Disable onclick callback immediately after rotate/pan
* Re-format the JavaScript file
* No onclick event set by user - properly treat this case now
* Further reformat - indentation
* Handle the case where there is no closest data point
* fixed label disappearing bug for large axis values in Graph3d
* only fixed label disappearing bug for large axis values in Graph3d
* very only fixed label disappearing bug for large axis values in Graph3d
* Added class Range for Min/Max value pairs.
* Processed review feedback, added comments.
* Fixed jsdoc tags; reviewed commenting
* Final fixes to commenting
wimrijnders
macleodbroad-wf
p-a
AoDev
nmehrle
Ephraim Berkovitch
linuxnotes
A
Kentaro Goto