jrtechs-vis

3108 Commits

33 Branches

634 MiB

Branch: revert-3409-performance

Commit Graph

Author	SHA1	Message	Date
wimrijnders	1ec51911d9	Network: Fixes sorting on Layout, refactoring. (#3411 ) * Network: Fixes sorting on Layout sorting, refactoring. Fix for #3403 Chromium has divergent behaviour on sorting of `undefined` values, a check has been added for these. The fix itself is small, it adds a check on `undefined` in the sorting function(s). In addition: - Fixed off-by-one error on tree index - Refactored away checks on visibility by replacing `_isVisible()` with a Strategy pattern for direction The latter removes a long-standing eyesore in `LayoutManager`; it's probably also faster. There is some hope that these fixes will improve the hierarchical layout initialization, which has had problems for quite a while. * reformat code block * Add next attempt to fix Travis unit test bug * Fix unit test - timeout * Adjustments for comment reviews * Moved direction strategies to separate module; added fix for 'window is undefined'	7 years ago

Author

SHA1

Message

Date

wimrijnders

1ec51911d9

Network: Fixes sorting on Layout, refactoring. (#3411 )

* Network: Fixes sorting on Layout sorting, refactoring.

Fix for #3403

Chromium has divergent behaviour on sorting of `undefined` values, a check has been added for these.

The fix itself is small, it adds a check on `undefined` in the sorting function(s).

In addition:

- Fixed off-by-one error on tree index
- Refactored away checks on visibility by replacing `_isVisible()` with a Strategy pattern for direction

The latter removes a long-standing eyesore in `LayoutManager`; it's probably also faster.

There is some hope that these fixes will improve the hierarchical layout initialization, which has had
problems for quite a while.

* reformat code block

* Add next attempt to fix Travis unit test bug

* Fix unit test - timeout

* Adjustments for comment reviews

* Moved direction strategies to separate module; added fix for 'window is undefined'

7 years ago

1 Commits (revert-3409-performance)