Fixed #670: bug when updating data in a DataSet, when Network is connected to the DataSet via a DataView

HISTORY.md

@@ -14,6 +14,7 @@ http://visjs.org
 - Added pull request for usage of Icons. Thanks @Dude9177!
 - Allow hierarchical view to be set in setOptions.
 - Fixed manipulation bar for mobile.
+- Fixed #670: bug when updating data in a DataSet, when Network is connected to the DataSet via a DataView.
 
 ### Graph2d
 

lib/network/Network.js

@@ -329,7 +329,7 @@ function Network (container, data, options) {
       network.start();
     },
     'update': function (event, params) {
-      network._updateNodes(params.items, params.data);
+      network._updateNodes(params.items);
       network.start();
     },
     'remove': function (event, params) {
@@ -1687,12 +1687,14 @@ Network.prototype._addNodes = function(ids) {
  * @param {Number[] | String[]} ids
  * @private
  */
-Network.prototype._updateNodes = function(ids,changedData) {
+Network.prototype._updateNodes = function(ids) {
+  var nodesData = this.nodesData.get(ids);
   var nodes = this.nodes;
+
   for (var i = 0, len = ids.length; i < len; i++) {
     var id = ids[i];
     var node = nodes[id];
-    var data = changedData[i];
+    var data = nodesData[i];
     if (node) {
       // update node
       node.setProperties(data, this.constants);