From e5d0b5996360f8ac7f72a2f20326e0516f2009f5 Mon Sep 17 00:00:00 2001
From: macleodbroad-wf <macleodbroad-wf@users.noreply.github.com>
Date: Tue, 1 Aug 2017 10:35:50 -0400
Subject: [PATCH] lint graph2d (#3307)

---
 lib/timeline/component/graph2d_types/bar.js    | 5 +----
 lib/timeline/component/graph2d_types/line.js   | 9 +++++----
 lib/timeline/component/graph2d_types/points.js | 6 ++----
 3 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/lib/timeline/component/graph2d_types/bar.js b/lib/timeline/component/graph2d_types/bar.js
index a8db2e24..fd85d770 100644
--- a/lib/timeline/component/graph2d_types/bar.js
+++ b/lib/timeline/component/graph2d_types/bar.js
@@ -1,13 +1,11 @@
 var DOMutil = require('../../../DOMutil');
 var Points = require('./points');
 
-function Bargraph(groupId, options) {
+function Bargraph(groupId, options) {  // eslint-disable-line no-unused-vars
 }
 
 Bargraph.drawIcon = function (group, x, y, iconWidth, iconHeight, framework) {
   var fillHeight = iconHeight * 0.5;
-  var path, fillPath;
-
   var outline = DOMutil.getSVGElement("rect", framework.svgElements, framework.svg);
   outline.setAttributeNS(null, "x", x);
   outline.setAttributeNS(null, "y", y - fillHeight);
@@ -108,7 +106,6 @@ Bargraph.draw = function (groupIds, processedGroupData, framework) {
     }
     else {
       var nextKey = i + (intersections[key].amount - intersections[key].resolved);
-      var prevKey = i - (intersections[key].resolved + 1);
       if (nextKey < combinedData.length) {
         coreDistance = Math.abs(combinedData[nextKey].screen_x - key);
       }
diff --git a/lib/timeline/component/graph2d_types/line.js b/lib/timeline/component/graph2d_types/line.js
index 18b9877b..c63a579a 100644
--- a/lib/timeline/component/graph2d_types/line.js
+++ b/lib/timeline/component/graph2d_types/line.js
@@ -1,6 +1,6 @@
 var DOMutil = require('../../../DOMutil');
 
-function Line(groupId, options) {
+function Line(groupId, options) {  // eslint-disable-line no-unused-vars
 }
 
 Line.calcPath = function (dataset, group) {
@@ -137,18 +137,19 @@ Line.serializePath = function(pathArray,type,inverse){
         return "";
     }
     var d = type;
+    var i;
     if (inverse){
-        for (var i = pathArray.length-2; i > 0; i--){
+        for (i = pathArray.length-2; i > 0; i--){
             d += pathArray[i][0] + "," + pathArray[i][1] + " ";
         }
     }
     else {
-        for (var i = 1; i < pathArray.length; i++){
+        for (i = 1; i < pathArray.length; i++){
             d += pathArray[i][0] + "," + pathArray[i][1] + " ";
         }
     }
     return d;
-}
+};
 
 /**
  * This uses an uniform parametrization of the interpolation algorithm:
diff --git a/lib/timeline/component/graph2d_types/points.js b/lib/timeline/component/graph2d_types/points.js
index c6a05a92..225b81b2 100644
--- a/lib/timeline/component/graph2d_types/points.js
+++ b/lib/timeline/component/graph2d_types/points.js
@@ -1,15 +1,14 @@
 var DOMutil = require('../../../DOMutil');
 
-function Points(groupId, options) {
+function Points(groupId, options) {  // eslint-disable-line no-unused-vars
 }
 
 /**
  * draw the data points
  *
  * @param {Array} dataset
- * @param {Object} JSONcontainer
- * @param {Object} svg            | SVG DOM element
  * @param {GraphGroup} group
+ * @param {Object} framework            | SVG DOM element
  * @param {Number} [offset]
  */
 Points.draw = function (dataset, group, framework, offset) {
@@ -32,7 +31,6 @@ Points.draw = function (dataset, group, framework, offset) {
 
 Points.drawIcon = function (group, x, y, iconWidth, iconHeight, framework) {
   var fillHeight = iconHeight * 0.5;
-  var path, fillPath;
 
   var outline = DOMutil.getSVGElement("rect", framework.svgElements, framework.svg);
   outline.setAttributeNS(null, "x", x);