From 38cdcf23bb35a3567816acb8154806ccde70fd2e Mon Sep 17 00:00:00 2001 From: Manuel Schallar Date: Thu, 11 Jun 2015 12:07:01 +0200 Subject: [PATCH 1/3] accessing the correct properties in dataRange + replaced property name 'start' to 'min' + replaced property name 'end' to 'max' --- lib/timeline/Core.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/timeline/Core.js b/lib/timeline/Core.js index e9176360..5c795990 100644 --- a/lib/timeline/Core.js +++ b/lib/timeline/Core.js @@ -459,7 +459,7 @@ Core.prototype.getVisibleItems = function() { Core.prototype.fit = function(options) { var range = this.getDataRange(); - // skip range set if there is no start and end date + // skip range set if there is no min and max date if (range.min === null && range.max === null) { return; } From d1e01bccf0eb39ca489d48a646af971c14ec7c53 Mon Sep 17 00:00:00 2001 From: Manuel Schallar Date: Thu, 11 Jun 2015 12:08:09 +0200 Subject: [PATCH 2/3] returning meaningful values in getDataRange + instead of returning 'null', returning the calculated values --- lib/timeline/Core.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/timeline/Core.js b/lib/timeline/Core.js index 5c795990..b90b841e 100644 --- a/lib/timeline/Core.js +++ b/lib/timeline/Core.js @@ -496,8 +496,8 @@ Core.prototype.getDataRange = function() { } return { - start: null, - end: null + start: start, + end: end } }; From d894d0efe5e4560ab8bcd71538c830fdb7bc3e01 Mon Sep 17 00:00:00 2001 From: Manuel Schallar Date: Thu, 11 Jun 2015 12:15:51 +0200 Subject: [PATCH 3/3] changing the properties from getDataRange + according to the documentation + changed from 'start' and 'end' to 'min' and 'max' --- lib/timeline/Core.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/timeline/Core.js b/lib/timeline/Core.js index b90b841e..348f35ad 100644 --- a/lib/timeline/Core.js +++ b/lib/timeline/Core.js @@ -496,8 +496,8 @@ Core.prototype.getDataRange = function() { } return { - start: start, - end: end + min: start, + max: end } };