Browse Source

Add vis-drag-center to fix dragging bug when template is react component

codeClimate
Yotam Berkowitz 8 years ago
parent
commit
3addd51046
5 changed files with 37 additions and 1 deletions
  1. +9
    -0
      lib/timeline/component/css/item.css
  2. +1
    -0
      lib/timeline/component/item/BoxItem.js
  3. +24
    -0
      lib/timeline/component/item/Item.js
  4. +2
    -1
      lib/timeline/component/item/PointItem.js
  5. +1
    -0
      lib/timeline/component/item/RangeItem.js

+ 9
- 0
lib/timeline/component/css/item.css View File

@ -136,6 +136,15 @@
color: white; color: white;
} }
.vis-item .vis-drag-center {
position: absolute;
width: 100%;
height: 100%;
top: 0;
left: 0px;
cursor: move;
}
.vis-item.vis-range .vis-drag-left { .vis-item.vis-range .vis-drag-left {
position: absolute; position: absolute;
width: 24px; width: 24px;

+ 1
- 0
lib/timeline/component/item/BoxItem.js View File

@ -164,6 +164,7 @@ BoxItem.prototype.redraw = function() {
this.dirty = false; this.dirty = false;
} }
this._repaintDragCenter();
this._repaintDeleteButton(dom.box); this._repaintDeleteButton(dom.box);
}; };

+ 24
- 0
lib/timeline/component/item/Item.js View File

@ -287,6 +287,7 @@ Item.prototype._updateStyle = function(element) {
} }
}; };
/** /**
* Stringify the items contents * Stringify the items contents
* @param {string | Element | undefined} content * @param {string | Element | undefined} content
@ -315,4 +316,27 @@ Item.prototype.getWidthRight = function () {
return 0; return 0;
}; };
/**
* Repaint a drag area on the center of the item when the item is selected
* @protected
*/
Item.prototype._repaintDragCenter = function () {
if (this.selected && this.options.editable.updateTime && !this.dom.dragCenter) {
// create and show drag area
var dragCenter = document.createElement('div');
dragCenter.className = 'vis-drag-center';
dragCenter.dragCenterItem = this;
this.dom.box.appendChild(dragCenter);
this.dom.dragCenter = dragCenter;
}
else if (!this.selected && this.dom.dragCenter) {
// delete drag area
if (this.dom.dragCenter.parentNode) {
this.dom.dragCenter.parentNode.removeChild(this.dom.dragCenter);
}
this.dom.dragCenter = null;
}
};
module.exports = Item; module.exports = Item;

+ 2
- 1
lib/timeline/component/item/PointItem.js View File

@ -140,7 +140,8 @@ PointItem.prototype.redraw = function() {
this.dirty = false; this.dirty = false;
} }
this._repaintDragCenter();
this._repaintDeleteButton(dom.point); this._repaintDeleteButton(dom.point);
}; };

+ 1
- 0
lib/timeline/component/item/RangeItem.js View File

@ -124,6 +124,7 @@ RangeItem.prototype.redraw = function() {
this.dirty = false; this.dirty = false;
} }
this._repaintDeleteButton(dom.box); this._repaintDeleteButton(dom.box);
this._repaintDragCenter();
this._repaintDragLeft(); this._repaintDragLeft();
this._repaintDragRight(); this._repaintDragRight();
}; };

Loading…
Cancel
Save