Fixed #279: `className` of groups not being updated when changed

HISTORY.md

@@ -17,7 +17,7 @@ http://visjs.org
 ### Timeline
 
 - Fixed moment.js url in localization example.
-
+- Fixed `className` of groups not being updated when changed.
 
 
 ## 2014-08-29, version 3.3.0

lib/timeline/component/Group.js

@@ -99,15 +99,16 @@ Group.prototype.setData = function(data) {
   var className = data && data.className || null;
   if (className != this.className) {
     if (this.className) {
-      util.removeClassName(this.dom.label, className);
-      util.removeClassName(this.dom.foreground, className);
-      util.removeClassName(this.dom.background, className);
-      util.removeClassName(this.dom.axis, className);
+      util.removeClassName(this.dom.label, this.className);
+      util.removeClassName(this.dom.foreground, this.className);
+      util.removeClassName(this.dom.background, this.className);
+      util.removeClassName(this.dom.axis, this.className);
     }
     util.addClassName(this.dom.label, className);
     util.addClassName(this.dom.foreground, className);
     util.addClassName(this.dom.background, className);
     util.addClassName(this.dom.axis, className);
+    this.className = className;
   }
 };
 

test/timeline_groups.html

@@ -51,7 +51,7 @@
   var names = ['John (0)', 'Alston (1)', 'Lee (2)', 'Grant (3)'];
   var groups = new vis.DataSet();
   for (var g = 0; g < groupCount; g++) {
-    groups.add({id: g, content: names[g], title: 'Title of group ' + g});
+    groups.add({id: g, content: names[g], title: 'Title of group ' + g, 'className': 'myGroup'});
   }
 
   // create a dataset with items
@@ -66,7 +66,8 @@
           ' <span style="color:#97B0F8;">(' + names[group] + ')</span>',
       start: start,
       title: 'Title for item ' + i,
-      type: 'box'
+      type: 'box',
+      className: 'myItem'
     });
   }