Fixed #402: background items not always be cleared when removing them

HISTORY.md

@@ -2,6 +2,13 @@
 http://visjs.org
 
 
+## not yet released, version 3.6.3
+
+### Timeline
+
+- Fixed background items not always be cleared when removing them.
+
+
 ## 2014-10-24, version 3.6.2
 
 - Vis.js is now dual licensed under both Apache 2.0 and MIT.

lib/timeline/component/Group.js

@@ -336,7 +336,7 @@ Group.prototype.orderSubgroups = function() {
       }
     }
   }
-}
+};
 
 Group.prototype.resetSubgroups = function() {
   for (var subgroup in this.subgroups) {
@@ -352,7 +352,7 @@ Group.prototype.resetSubgroups = function() {
  */
 Group.prototype.remove = function(item) {
   delete this.items[item.id];
-  item.setParent(this.itemSet);
+  item.setParent(null);
 
   // remove from visible items
   var index = this.visibleItems.indexOf(item);

lib/timeline/component/ItemSet.js

@@ -600,12 +600,7 @@ ItemSet.prototype._updateUngrouped = function() {
       for (itemId in this.items) {
         if (this.items.hasOwnProperty(itemId)) {
           item = this.items[itemId];
-          if (item instanceof BackgroundItem) {
-            background.add(item);
-          }
-          else {
-            ungrouped.add(item);
-          }
+          ungrouped.add(item);
         }
       }
 
@@ -776,8 +771,8 @@ ItemSet.prototype._getType = function (itemData) {
  */
 ItemSet.prototype._getGroupId = function (itemData) {
   var type = this._getType(itemData);
-  if (type == 'background') {
-   return this.groupsData && itemData.group != undefined ? itemData.group : BACKGROUND;
+  if (type == 'background' && itemData.group == undefined) {
+   return BACKGROUND;
   }
   else {
     return this.groupsData ? itemData.group : UNGROUPED;
@@ -1045,9 +1040,7 @@ ItemSet.prototype._removeItem = function(item) {
   if (index != -1) this.selection.splice(index, 1);
 
   // remove from group
-  var groupId = this._getGroupId(item.data);
-  var group = this.groups[groupId];
-  if (group) group.remove(item);
+  item.parent && item.parent.remove(item);
 };
 
 /**