From 0ae676c424e6a0b2dc72b1b5bbb04da5c9520464 Mon Sep 17 00:00:00 2001 From: Ben Morton Date: Wed, 26 Apr 2017 18:25:33 +0100 Subject: [PATCH] Add check for empty groupIds array and get full list from data set. Fixes #2877 (#2986) --- lib/timeline/component/ItemSet.js | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/lib/timeline/component/ItemSet.js b/lib/timeline/component/ItemSet.js index fe2b46f6..e0019df8 100644 --- a/lib/timeline/component/ItemSet.js +++ b/lib/timeline/component/ItemSet.js @@ -2233,8 +2233,16 @@ ItemSet.prototype.itemFromRelatedTarget = function(event) { */ ItemSet.prototype.groupFromTarget = function(event) { var clientY = event.center ? event.center.y : event.clientY; - for (var i = 0; i < this.groupIds.length; i++) { - var groupId = this.groupIds[i]; + var groupIds = this.groupIds; + + if (groupIds.length <= 0) { + groupIds = this.groupsData.getIds({ + order: this.options.groupOrder + }); + } + + for (var i = 0; i < groupIds.length; i++) { + var groupId = groupIds[i]; var group = this.groups[groupId]; var foreground = group.dom.foreground; var top = util.getAbsoluteTop(foreground);