From ec3712685d021794e2fb5e1df9dbf4354452933d Mon Sep 17 00:00:00 2001
From: jrtechs <jxr8142@rit.edu>
Date: Sun, 17 Feb 2019 02:15:07 -0500
Subject: [PATCH 1/3] Improved security of web server.

---
 configManager.js         |  6 ------
 public/FriendsGraph.html |  3 +--
 routes/api.js            | 26 ++++++++++----------------
 3 files changed, 11 insertions(+), 24 deletions(-)

diff --git a/configManager.js b/configManager.js
index c77a328..8c48aa9 100644
--- a/configManager.js
+++ b/configManager.js
@@ -33,11 +33,5 @@ module.exports=
         getSessionSecret: function()
         {
             return config.sessionSecret;
-        },
-
-        getAPIUser: function()
-        {
-            return config.user;
         }
-
     };
\ No newline at end of file
diff --git a/public/FriendsGraph.html b/public/FriendsGraph.html
index a9156bd..d845911 100644
--- a/public/FriendsGraph.html
+++ b/public/FriendsGraph.html
@@ -54,7 +54,7 @@
 
         <div class="row">
             <div class="col-md-8 col-12">
-                <h2 id="graphLabel"></h2>
+                <h2 id="graphLoading"></h2>
                 <div id="myGraph" class="w-100"></div>
                 <pre id="eventSpan"></pre>
             </div>
@@ -62,7 +62,6 @@
                 <div id="profileGen"></div>
             </div>
         </div>
-
 <script>
 
     function createGraphs(username)
diff --git a/routes/api.js b/routes/api.js
index 5d4eac5..5052743 100644
--- a/routes/api.js
+++ b/routes/api.js
@@ -34,6 +34,7 @@ function queryGitHubAPI(requestURL)
             {
                 queryURL = GITHUB_API + requestURL + "?" + authenticate;
             }
+            console.log(queryURL);
 
             got(queryURL, { json: true }).then(response =>
             {
@@ -41,12 +42,9 @@ function queryGitHubAPI(requestURL)
                 cache.put(requestURL, response.body);
             }).catch(error =>
             {
-                // resolve(response.body);
-                // cache.put(requestURL, response.body);
-                console.log(error);
                 reject(error);
+                cache.put(requestURL, response.body);
             });
-
         }
         else
         {
@@ -60,24 +58,20 @@ routes.get('/*', (request, result) =>
 {
     var gitHubAPIURL = request.url;
 
-    // if(request.query.hasOwnProperty("page"))
-    // {
-    //     gitHubAPIURL += "?page=" + request.query.page;
-    // }
-
-    console.log(request.query);
-
-    console.log(gitHubAPIURL);
-
-
     result.setHeader('Content-Type', 'application/json');
     queryGitHubAPI(gitHubAPIURL).then(function(data)
     {
-        result.write(JSON.stringify(data));
+        if(data.hasOwnProperty("id"))
+        {
+            result.write(JSON.stringify(data));
+        }
         result.end();
     }).catch(function(error)
     {
-        result.write(JSON.stringify(error));
+        if(error.hasOwnProperty("id"))
+        {
+            result.write(JSON.stringify(error));
+        }
         result.end();
     })
 });

From 13662bc75541eea9de4b8d17aebea1d386234704 Mon Sep 17 00:00:00 2001
From: jrtechs <jxr8142@rit.edu>
Date: Sun, 17 Feb 2019 02:20:53 -0500
Subject: [PATCH 2/3] hot fix

---
 routes/api.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/routes/api.js b/routes/api.js
index 5052743..b5d36a0 100644
--- a/routes/api.js
+++ b/routes/api.js
@@ -61,14 +61,14 @@ routes.get('/*', (request, result) =>
     result.setHeader('Content-Type', 'application/json');
     queryGitHubAPI(gitHubAPIURL).then(function(data)
     {
-        if(data.hasOwnProperty("id"))
+        if(data.hasOwnProperty("id") || data[0].hasOwnProperty("id"))
         {
             result.write(JSON.stringify(data));
         }
         result.end();
     }).catch(function(error)
     {
-        if(error.hasOwnProperty("id"))
+        if(error.hasOwnProperty("id") || error[0].hasOwnProperty("id"))
         {
             result.write(JSON.stringify(error));
         }

From dc23245529f065c05835e71d86823a020449694f Mon Sep 17 00:00:00 2001
From: jrtechs <jxr8142@rit.edu>
Date: Sun, 17 Feb 2019 03:13:11 -0500
Subject: [PATCH 3/3] Memory improvements to the project.

---
 public/js/friendsGraph.js |  4 ++--
 routes/api.js             | 20 +++++++++++++++-----
 2 files changed, 17 insertions(+), 7 deletions(-)

diff --git a/public/js/friendsGraph.js b/public/js/friendsGraph.js
index 07bf5e4..28f97c0 100644
--- a/public/js/friendsGraph.js
+++ b/public/js/friendsGraph.js
@@ -82,7 +82,7 @@ function addFriends(username, apiPath, page)
                 }
             }
 
-            if(data.length === 30)
+            if(page < 50 && data.length === 30)
             {
                 addFriends(username, apiPath, page+ 1).then(function()
                 {
@@ -161,7 +161,7 @@ function processConnections(user, apiPoint, page)
                 {
                     addConnection(user, data[i])
                 }
-                if(data.length === 30)
+                if(page < 50 && data.length === 30)
                 {
                     processConnections(user, apiPoint, page + 1).then(function()
                     {
diff --git a/routes/api.js b/routes/api.js
index b5d36a0..0c0befb 100644
--- a/routes/api.js
+++ b/routes/api.js
@@ -42,12 +42,13 @@ function queryGitHubAPI(requestURL)
                 cache.put(requestURL, response.body);
             }).catch(error =>
             {
-                reject(error);
-                cache.put(requestURL, response.body);
+                resolve(error);
+                cache.put(requestURL, error);
             });
         }
         else
         {
+            console.log("Fetched From Cahce");
             resolve(apiData);
         }
     })
@@ -68,12 +69,21 @@ routes.get('/*', (request, result) =>
         result.end();
     }).catch(function(error)
     {
-        if(error.hasOwnProperty("id") || error[0].hasOwnProperty("id"))
+        try
         {
-            result.write(JSON.stringify(error));
+            if(error.hasOwnProperty("id") || error[0].hasOwnProperty("id"))
+            {
+                result.write(JSON.stringify(error));
+            }
         }
+        catch(error) {};
         result.end();
-    })
+    });
+
+    if(cache.size() > 500000)
+    {
+        cache.clear();
+    }
 });
 
 module.exports = routes;
\ No newline at end of file